Comments on: Dojo charts that sing: box and whisker plots

By: pogil

pogil — Tue, 31 Mar 2009 20:20:53 +0000

I’ve updated the code again to use Adrian’s fix of not using a height of 0.5.

I also greatly improved the support for negative numbers to address Yuri’s problems and I think I am now correctly handing automatic axis range creation.

Adrian and Yuri, I’d be interested in hearing whether your problems are now resolved.

By: Adrian N

Adrian N — Tue, 24 Mar 2009 12:34:09 +0000

I have temporarily solved the problem by changing height from 0.5 to 1 It seems that IE does not like the decimal point. This needs to be changed for all heights. Then all works OK

s.createRect… , height: 1

By: pogil

pogil — Mon, 23 Mar 2009 12:45:26 +0000

Adrian, thanks for digging into this further. I’ll try to take a look at this and Yuri’s problem later this week.

By: Adrian N

Adrian N — Mon, 23 Mar 2009 12:38:40 +0000

On further investigation, it appears that there are NaN results trying to be assigned to number vars. In Firefox these are ignored, and rendering continues. In IE they are flagged up as an error and rendering stops.

By: Adrian N

Adrian N — Mon, 16 Mar 2009 09:59:50 +0000

I find the example shown renders correctly in Firefox but not in IE which gives an illegal character Vector2D line 146 char 17

By: Yuri N

Yuri N — Sun, 15 Mar 2009 19:50:39 +0000

Great stuff. There is still a problem with ranges containing negative numbers. It seems to work when you just supply the arrays of values for the series. But if you send the objects with the properties lwisker, uwisker, median, etc, it does not display below the zero line.

By: pogil

pogil — Fri, 19 Dec 2008 00:12:20 +0000

Tom, thanks for catching that bug. I’ve updated the code on my server and added a comment to the ticket in the Dojo Toolkit’s Trac system.

By: Tom C

Tom C — Thu, 18 Dec 2008 23:51:36 +0000

Thanks Paul. This is very nice.

I did find one problem with the code, however. It looks like the charts fail if you have orders-of-magnitude differences in the data values.

For a simple example, consider this data:
[1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 10]

This doesn’t work due to a bug in the code that sorts the data before doing the calculations.
run.data.sort() does not do what you think it would. It sorts alphabetically (even for numbers!), so the above data end up looking like this:

[1, 1, 10, 2, 2, 3, 3, 4, 4, 5, 5]

(See: http://www.w3schools.com/jsref/jsref_sort.asp)

I added a sort function locally, and it works like a charm.

Great chart. I hope to see it added to the distro soon.